Add Java 21 GitHub Actions CI workflow #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brijeshthummar02 <[email protected]>
Brijeshthummar02
force-pushed
the
java-21
branch
from
29888e9 to
6b49495
Compare
|
@dearrudam update on this one as well. |
dearrudam
approved these changes
Feb 18, 2025
dearrudam
previously requested changes
Feb 18, 2025
There was a problem hiding this comment.
@Brijeshthummar02 thanks for your contribution👏 ! Could you improve the other ones as well: java-11.yml and java-17.yml?
|
@dearrudam Sure! but what i suggest for java-11.yml and java-17.yml there needs to be 2 more new PR as it will help to maintain the structure and if anything goes off we can make changes specifically for that PR. |
|
@dearrudam this PR is perfect right we don't need changes in this one right only for java 11-17. |
dearrudam
dismissed
their stale review
The requested changes will be done in additional separated PRs.
dearrudam
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #28
i have tested it locally